Skip to content

Commit

Permalink
Update base.py revert grpc_port changes (ydb-platform#14745)
Browse files Browse the repository at this point in the history
  • Loading branch information
sourcecd authored Feb 18, 2025
1 parent d1f5b91 commit 2f33cfe
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions ydb/tools/cfg/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -709,12 +709,7 @@ def default_log_level(self):

@property
def grpc_config(self):
grpc_config = merge_with_default(GRPC_DEFAULT_CONFIG, self.__cluster_description.get("grpc", {}))
# specifying both `port` and `ssl_port` leads to erroneous behavior in ydbd, half of the incoming
# connections use tls, half do not, so this is prohibited
if grpc_config.get("ssl_port") is not None:
del grpc_config["port"]
return grpc_config
return merge_with_default(GRPC_DEFAULT_CONFIG, self.__cluster_description.get("grpc", {}))

@property
def dynamicnameservice_config(self):
Expand Down

0 comments on commit 2f33cfe

Please sign in to comment.