Update composer to use correct autoload setting for tests #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPry
added a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 27, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
JPry
added a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 27, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
serbanghita
approved these changes
Oct 27, 2023
|
@JPry thank you! 🙇 I will release a new version today! |
|
Thanks @serbanghita! |
layoutd
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Nov 11, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
layoutd
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Nov 13, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
layoutd
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Nov 14, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
layoutd
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Nov 20, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
layoutd
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Nov 21, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
layoutd
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Nov 24, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
layoutd
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Nov 27, 2023
For now, this manually adds the mobile detect library, due to an error that should be fixed by serbanghita/Mobile-Detect#944.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
composer.jsonfile to move theautoloadsetting fortests/intoautoload-dev.The reason for this change is that the
tests/directory is (correctly) not inculded in distribution, but including it in the normalautoloadproperty still specifies the testing namespace. In distribution, this namespace doesn't exist.More specifically, if we attempt to use a 3rd party tool (such as Mozart) to add a prefix to this namespace, the extraneous namespace for
tests/causes an error to be thrown. Moving the namespace toautoload-devsolves this issue.