Merge pull request kubernetes#81547 from BenTheElder/typecheck-cleanup

typecheck cleanup
serathius · Aug 17, 2019 · f12a40d · f12a40d
2 parents 3f00331 + 6b038f3
commit f12a40d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 22 deletions.
diff --git a/test/typecheck/OWNERS b/test/typecheck/OWNERS
@@ -1,8 +1,8 @@
 # See the OWNERS docs at https://go.k8s.io/owners
 
 reviewers:
+  - BenTheElder
   - cblecker
-  - rmmh
 approvers:
   - cblecker
   - rmmh
diff --git a/test/typecheck/main.go b/test/typecheck/main.go
@@ -103,26 +103,6 @@ func newAnalyzer(platform string) *analyzer {
 }
 
 func (a *analyzer) handleError(err error) {
-	if e, ok := err.(types.Error); ok {
-		// useful for some ignores:
-		// path := e.Fset.Position(e.Pos).String()
-		ignore := false
-		// TODO(rmmh): read ignores from a file, so this code can
-		// be Kubernetes-agnostic. Unused ignores should be treated as
-		// errors, to ensure coverage isn't overly broad.
-		if strings.Contains(e.Msg, "GetOpenAPIDefinitions") {
-			// TODO(rmmh): figure out why this happens.
-			// cmd/kube-apiserver/app/server.go:392:70
-			// test/integration/framework/master_utils.go:131:84
-			ignore = true
-		}
-		if ignore {
-			if *verbose {
-				fmt.Println("ignoring error:", err)
-			}
-			return
-		}
-	}
 	a.errors = append(a.errors, err.Error())
 	if *serial {
 		fmt.Fprintf(os.Stderr, "%sERROR(%s) %s\n", logPrefix, a.platform, err)

diff --git a/third_party/go-srcimporter/OWNERS b/third_party/go-srcimporter/OWNERS
@@ -1,8 +1,8 @@
 # See the OWNERS docs at https://go.k8s.io/owners
 
 reviewers:
+  - BenTheElder
   - cblecker
-  - rmmh
 approvers:
   - cblecker
   - rmmh