Skip to content
This repository was archived by the owner on Jun 12, 2024. It is now read-only.

fix macos gcc build by removing unneeded obj-c deps #9

Merged
merged 5 commits into from
Apr 11, 2019

Conversation

d4tocchini
Copy link
Contributor

MacOS build breaks when building with gnu tools via:

CC=gcc-8 CXX=g++-8 cmake ..

Apple builds currently require clang due to Objective-C deps. Turns out gcc support for modern obj-c 2.0 is not trivial without a rabbit hole of GNUstep and what not. Apple specific use of obj-c was isolated to sx_os_numcores and a bit of NSLog, both of which can be replaced with simpler solutions without such heavy handed os deps.

This pull request allows mac builds with gcc, opening potential use with such things as gcc LTO. clang still works, only diff being lighter-weight binaries. I have not tested impact with iOS targets.

Copy link
Owner

@septag septag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.
but could you cleanup some more before merging ?

  • the changes in jobs.h and job.c should be discarded (formatting changes)
  • remove more comments in test-jobs.c
  • remove comments from sx.c
  • remove comments from CMakeLists.txt

@d4tocchini
Copy link
Contributor Author

@septag, done & done

@septag septag merged commit 7b7a114 into septag:master Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants