Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: ValueError when using Decimal 0.x #339

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Bugfix: ValueError when using Decimal 0.x #339

merged 1 commit into from
Aug 25, 2022

Conversation

epou
Copy link

@epou epou commented Aug 17, 2022 •
edited
Loading

@epou epou force-pushed the bugfix_valueerror_decimal_zero branch 4 times, most recently from d674ef0 to cfab1ea Compare August 18, 2022 09:43
seperman
seperman reviewed Aug 22, 2022
View reviewed changes
Copy link
Owner

@seperman seperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @epou
Thanks for the PR! It looks great. Do you mind adding a test case that covers the changes for complex numbers? We already have 2 tests for complex numbers but I'm not sure why more code was needed to handle complex numbers.

@seperman
Copy link
Owner

I'm gonna be cutting a new release so gonna merge this.

@epou
Copy link
Author

epou commented Aug 25, 2022

Let me add some more tests before. I'll do it today

@epou epou force-pushed the bugfix_valueerror_decimal_zero branch from cfab1ea to 4a1e5b3 Compare August 25, 2022 08:27
@epou
Copy link
Author

epou commented Aug 25, 2022

I've updated the PR. Let me know your opinion :D

@seperman
Copy link
Owner

@epou
Thanks for the update! LGTM. Merging.

@seperman seperman merged commit 8420f42 into seperman:dev Aug 25, 2022
@seperman seperman mentioned this pull request Aug 26, 2022
Merged
4 tasks
@seperman
Copy link
Owner

@epou DeepDiff 6.1.0 is published. It includes your PR. Thanks.
https://zepworks.com/deepdiff/current/

@epou epou mentioned this pull request Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seperman seperman seperman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epou @seperman