Split agent subscriptions properly in CLI flags #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where agents were sending the wrong subscriptions in entities, as they would not be split properly before being sent to the config. Due to a quirk in how subscriptions are handled, this doesn't affect any current scheduling mechanism. Nevertheless, subscriptions must be properly stored in entities, especially for future work that depends on entity details being correct. Signed-off-by: Eric Chlebek <eric@sensu.io>
palourde
reviewed
Feb 26, 2019
Signed-off-by: Eric Chlebek <eric@sensu.io>
|
@palourde I've incorporated your suggestion and verified that it works. Thanks again! |
ccressent
approved these changes
Mar 4, 2019
Signed-off-by: Eric Chlebek <eric@sensu.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This commit fixes a bug where agents were sending the wrong
subscriptions in entities, as they would not be split properly
before being sent to the config.
Due to a quirk in how subscriptions are handled, this doesn't
affect any current scheduling mechanism. Nevertheless,
subscriptions must be properly stored in entities, especially for
future work that depends on entity details being correct.
Why is this change necessary?
Closes #2753
Does your change need a Changelog entry?
Yes
Have you reviewed and updated the documentation for this change? Is new documentation required?
No doc changes required.
How did you verify this change?
Manual verification.