Guide to use Prometheus collector with Sensu Go #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwjohnston
suggested changes
Jan 4, 2019
Co-Authored-By: rgeniesse <richard.geniesse@gmail.com>
Co-Authored-By: rgeniesse <richard.geniesse@gmail.com>
Co-Authored-By: rgeniesse <richard.geniesse@gmail.com>
|
@cwjohnston, I've added a Why section. Can you take a look? Still not happy with it, but wanted to get something pushed. Thanks! |
cwjohnston
previously requested changes
Jan 25, 2019
There was a problem hiding this comment.
Some minor wording changes in the prometheus example. We may also want to link to this list of exporters https://prometheus.io/docs/instrumenting/exporters/
Co-Authored-By: rgeniesse <richard.geniesse@gmail.com>
|
@cwjohnston good points. I've taken that feedback and added links to both mentioned resources. |
cwjohnston
reviewed
Feb 4, 2019
Co-Authored-By: rgeniesse <richard.geniesse@gmail.com>
apaskulin
approved these changes
Feb 11, 2019
|
There's been some new versions and content reorganization since this was opened, so I'd suggest waiting to copy to all version in a separate PR. |
Changes done and approved by Alex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #850
Motivation and Context
Closes #850
Review Instructions
Run through guide in new CentOS 7 image.