Update configuration #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neirda24
requested changes
Mar 19, 2024
This reverts commit 134fe75.
…dle-configuration # Conflicts: # src/Builder/AbstractPdfBuilder.php
Neirda24
reviewed
Apr 1, 2024
Neirda24
approved these changes
Apr 11, 2024
|
@Jean-Beru can you approve or check another time 😉 |
Jean-Beru
approved these changes
Apr 11, 2024
| @@ -194,7 +193,7 @@ public function nativePageRanges(string $range): static | |||
| } | |||
|
|
|||
| /** | |||
| * @param string $template #Template | |||
| * @param string $template #Template | |||
There was a problem hiding this comment.
CS fixer won't be happy but 👍 for now. I'll fix it in my "add CI" PR .
|
@StevenRenaux let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring + renaming the bundle configuration.
Refactor the stream around a
formFieldsarray tomultipartFormDataso that it is directly formatted by the getter.