Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the Enum namespace #3

Closed
Jean-Beru opened this issue Dec 18, 2023 · 3 comments · Fixed by #61
Closed

Change the Enum namespace #3

Jean-Beru opened this issue Dec 18, 2023 · 3 comments · Fixed by #61
Milestone
v0.1.0

Comments

@Jean-Beru
Copy link
Contributor

Using Enum as part of the namespace is discouraged since it is a soft reserved word and may be reserved in future versions.
@StevenRenaux
Copy link
Collaborator

What do you suggest?
WDYT of ConfigurationOptions?

@Neirda24 Neirda24 added this to the v8.0.0 milestone May 28, 2024
@MaximePinot
Copy link
Contributor

Can we simply rename it as Enumeration?

@Jean-Beru
Copy link
Contributor Author

Why not. Be creative 😄

MaximePinot added a commit that referenced this issue Jun 5, 2024
@MaximePinot
Rename Enum namespace to Enumeration
f51af4b 
`Enum` is a soft-reserved keyword by PHP
Closes #3
@MaximePinot MaximePinot mentioned this issue Jun 5, 2024
Merged
MaximePinot added a commit that referenced this issue Jun 5, 2024
@MaximePinot
Rename Enum namespace to Enumeration
6f80a82 
`Enum` is a soft-reserved keyword by PHP
Closes #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Rename Enum namespace to Enumeration sensiolabs/GotenbergBundle
4 participants
@Jean-Beru @Neirda24 @MaximePinot @StevenRenaux