Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request]: Config SerialPlotter port via #define #34

Closed
leon0399 opened this issue Nov 29, 2022 · 0 comments
Closed

[Request]: Config SerialPlotter port via #define #34

leon0399 opened this issue Nov 29, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone
0.5.0 - Configura...

Comments

@leon0399
Copy link
Member

Implementation PR

No response

Reference Issues

No response

Summary

Allow changing SerialPlotter port with #defines, to later use with Configurable firmware builder

Basic Example

Add config for serial plotter component: enable, port, baudrate

Accept HardwareSerial port as input for SerialPlotter, open port in setup() function

Drawbacks

With this implementation submitted port must be reserved for using only with SerialPlotter

Unresolved questions

No response
@leon0399 leon0399 added the enhancement New feature or request label Nov 29, 2022
@leon0399 leon0399 added this to the 0.5.0 - Configuration update milestone Nov 29, 2022
@leon0399 leon0399 changed the title [Request]: Config SerialPlotter port via #define Request: Config SerialPlotter port via #define Nov 29, 2022
@leon0399 leon0399 changed the title Request: Config SerialPlotter port via #define [Request]: Config SerialPlotter port via #define Dec 1, 2022
leon0399 added a commit that referenced this issue Mar 28, 2023
@leon0399
build(PlatformIO): use defines for repeated configs
3f0211f 
Close #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0 - Configuration update
Development

No branches or pull requests
1 participant
@leon0399