Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Refactor auto and auto_margins output #26

Closed
leon0399 opened this issue Nov 24, 2022 · 0 comments
Closed

[Request]: Refactor auto and auto_margins output #26

leon0399 opened this issue Nov 24, 2022 · 0 comments
Labels
Component: Output enhancement New feature or request

Comments

@leon0399
Copy link
Member

leon0399 commented Nov 24, 2022

Original comment issue in #24

I decoupled output writes themselves (e.g. activate closest motors to requested output, or interpolate between surrounding motors) and registering motors input, like auto and auto with margins (btw, auto with margins makes more sense IMO)
These output changes will simplify things for part of #6 issue - in-cloud on-demand firmware builder for WebSerial flash

Difference between `auto` and `auto with margins`

* - motor
= - empty space

Auto:

*=========*
*=========*
*=========*

Auto with margins:

===*===*===
===*===*===
===*===*===

But I'm not entirely sold on my solution now, cause:

  1. We need to have 4 different options (Coordinates based on this: [WIP] [RFC]: OpenHaptics protocol #9):
    • both X and Y axes use auto
    • both X and Y axes use auto with margins
    • X uses auto and Y uses auto with margins
    • X uses auto with margins and Y uses auto
    • Something more custom:
      image
  2. For a more DRY approach, the same functions should be used for the make_point functions in all current bHaptics configs

As for now, 2nd requirement is partly achieved, but due to 1st is not met, it is not customizable at all

That is all because my vision for the future is entirely different from the current bHaptics BLE protocol allows:

  • it is limited to 40 output points max
  • because of DIY nature of project, other configurations must be achievable also (e.g. 32 vest, with only PCAs used, without ledc, x8 vest for very lightweight setups, etc)

Originally posted by @leon0399 in #24 (comment)

@leon0399 leon0399 added this to the 0.4.0 - Cleanup milestone Nov 24, 2022
@leon0399 leon0399 added the enhancement New feature or request label Nov 28, 2022
@leon0399 leon0399 changed the title Refactor auto and auto_margins output [Request]: Refactor auto and auto_margins output Dec 1, 2022
leon0399 added a commit that referenced this issue Mar 28, 2023
@volta-net volta-net bot closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Output enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant