fix: resolve compiler warnings

docs/DEVELOPMENT.md

@@ -15,7 +15,7 @@ Function argument: `snake_case`
 ### Fix `clang-format`
 
 ```shell
-find lib include firmware test examples -type f -regex '.*\.\(cpp\|hpp\|cu\|c\|h\)' ! -regex '^lib/frozen\(/.*\)' -exec clang-format-16 -style=file -i {} \;
+find lib include firmware test examples variants -type f -regex '.*\.\(cpp\|hpp\|cu\|c\|h\)' -exec clang-format-16 -style=file -i {} \;
 ```
 
 # Debugging

lib/bhaptics/senseshift/bh/encoding.hpp

@@ -29,7 +29,7 @@ class Decoder {
       FloatBody* output,
       const std::array<std::uint8_t, N>& value,
       const std::array<OutputLayout, N>& layout,
-      const Effect effect
+      const Effect
     )
     {
         for (size_t i = 0; i < N; i++) {
@@ -59,7 +59,7 @@ class Decoder {
       FloatBody* output,
       const std::array<std::uint8_t, N>& value,
       const std::array<Position, N>& layout,
-      const Effect effect,
+      const Effect,
       const Target target
     )
     {
@@ -137,7 +137,7 @@ class Decoder {
         std::array<std::uint8_t, VEST_LAYOUT_SIZE> result{};
 
         // Unpack values
-        for (auto i = 0; i < VEST_PAYLOAD_SIZE; i++) {
+        for (size_t i = 0; i < VEST_PAYLOAD_SIZE; i++) {
             const std::uint8_t byte = value[i];
             const size_t actIndex = i * 2;
 
@@ -146,7 +146,7 @@ class Decoder {
         }
 
         // Assign max value into each group
-        for (auto i = 0; i < N; i++) {
+        for (size_t i = 0; i < N; i++) {
             auto groupIndex = layoutGroups[i];
 
             if (groupIndex % 10 >= 4) {

lib/freertos/senseshift/freertos/task.hpp

@@ -142,7 +142,6 @@ class ComponentUpdateTask : public Task<ComponentUpdateTask<Tp>> {
     [[noreturn]] void run()
     {
         auto now = millis();
-        auto targetHz = 1000 / this->updateDelay_;
 
         while (true) {
             now = millis();
@@ -151,7 +150,7 @@ class ComponentUpdateTask : public Task<ComponentUpdateTask<Tp>> {
 
             const auto elapsed = millis() - now;
 
-            log_d("T: %d, Fmax: %dHz, Ft: %dHz", elapsed, 1000 / elapsed, targetHz);
+            log_d("T: %d, Fmax: %dHz, Ft: %dHz", elapsed, 1000 / elapsed, 1000 / this->updateDelay_);
             if (elapsed < this->updateDelay_) {
                 delay(this->updateDelay_ - elapsed);
             }

lib/io/senseshift/input/calibration.hpp

@@ -245,7 +245,7 @@ class FixedCenterPointDeviationCalibrator : public ICalibrator<Tp> {
     void reset() override
     {
     }
-    void update(ValueType input) override
+    void update(ValueType) override
     {
     }
 

lib/io/senseshift/input/filter.hpp

@@ -259,9 +259,9 @@ class ExponentialMovingAverageFilter : public IFilter<Tp> {
 
 /// Deadzone filter. Clamps acc_ to center if it is within the deadzone.
 /// Usually used to filter out noise in the joystick.
-class CenterDeadzoneFilter : public IFilter<float> {
+class SinglePointDeadzoneFilter : public IFilter<float> {
   public:
-    explicit CenterDeadzoneFilter(float deadzone, float center = 0.5F) : deadzone_(deadzone), center_(center){};
+    explicit SinglePointDeadzoneFilter(float deadzone, float center = 0.5F) : deadzone_(deadzone), center_(center){};
 
     inline auto filter(ISimpleSensor<float>* /*sensor*/, float value) -> float override
     {
@@ -270,11 +270,12 @@ class CenterDeadzoneFilter : public IFilter<float> {
     }
 
   private:
+    const float deadzone_;
     const float center_;
-
-    float deadzone_;
 };
 
+using CenterDeadzoneFilter = SinglePointDeadzoneFilter;
+
 /// Interpolates the value from the lookup table.
 /// Can be used to determine battery level from the voltage.
 ///

lib/io/senseshift/input/sensor.hpp

@@ -142,7 +142,7 @@ class SimpleSensorDecorator : public Sensor<Tp> {
     using ValueType = Tp;
     using SourceType = ISimpleSensor<ValueType>;
 
-    explicit SimpleSensorDecorator(SourceType* source) : source_(source), Sensor<Tp>()
+    explicit SimpleSensorDecorator(SourceType* source) : Sensor<Tp>(), source_(source)
     {
     }
 

lib/io/senseshift/input/sensor/analog_threshold.hpp

@@ -16,8 +16,8 @@ class AnalogThresholdSensor : public BinarySensor {
       Sensor<Tp>* source, Tp threshold_upper, Tp threshold_lower, bool attach_callbacks = false
     ) :
       source_(source),
-      threshold_upper_(threshold_upper),
       threshold_lower_(threshold_lower),
+      threshold_upper_(threshold_upper),
       attach_callbacks_(attach_callbacks)
     {
     }

lib/math/senseshift/math/point2.hpp

@@ -27,6 +27,15 @@ struct Point2 {
     {
     }
 
+    constexpr auto operator=(const Point2<Tp>& v) -> Point2&
+    {
+        if (this != &v) {
+            x = v.x;
+            y = v.y;
+        }
+        return *this;
+    }
+
     constexpr inline auto operator==(const Point2<Tp>& rhs) const -> bool
     {
         return x == rhs.x && y == rhs.y;

lib/opengloves/senseshift/opengloves/autoconfig.hpp

@@ -453,9 +453,14 @@ auto createTransport() -> ITransport*
 #ifdef BTSERIAL_NAME
     name = BTSERIAL_NAME;
 #else
-    char suffix[4];
-    snprintf(suffix, 4, "%04X", (uint16_t) (ESP.getEfuseMac() >> 32));
-    name = BTSERIAL_PREFIX + std::string(suffix);
+    char suffix[5];
+    int n = snprintf(suffix, 5, "%04X", (uint16_t) (ESP.getEfuseMac() >> 32));
+    if (n < 0) {
+        log_e("Failed to generate Bluetooth name");
+    } else {
+        suffix[4] = '\0';
+        name = BTSERIAL_PREFIX + std::string(suffix, 4);
+    }
 
     log_i("Generated Bluetooth name: %s", name.c_str());
 #endif

test/test_battery/main.cpp

@@ -57,7 +57,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_bhaptics_encoding/main.cpp

@@ -292,7 +292,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_body_gestures/main.cpp

@@ -111,7 +111,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_core_helpers/main.cpp

@@ -133,7 +133,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_haptics_body/main.cpp

@@ -106,7 +106,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_haptics_plane/main.cpp

@@ -237,7 +237,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_io_calibration/main.cpp

@@ -146,7 +146,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_io_filter/main.cpp

@@ -206,7 +206,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_io_sensor/main.cpp

@@ -94,7 +94,7 @@ class DummyCalibrator : public ::SenseShift::Input::Calibration::ICalibrator<flo
     {
         this->calibrated = input;
     }
-    float calibrate(float input) const override
+    float calibrate(float) const override
     {
         return calibrated;
     }
@@ -264,7 +264,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }

test/test_math_point2/main.cpp

@@ -79,7 +79,7 @@ void loop(void)
 
 #else
 
-int main(int argc, char** argv)
+int main()
 {
     return process();
 }