chore: remove unnecessary [[nodiscard]] attributes

include/senseshift.h

@@ -13,7 +13,7 @@ class Application final : public IEventDispatcher {
   public:
     Application();
 
-    [[nodiscard]] auto getVibroBody() const -> Body::Haptics::FloatBody*
+    auto getVibroBody() const -> Body::Haptics::FloatBody*
     {
         return this->vibro_body_;
     }

lib/arduino/senseshift/arduino/input/sensor/analog.hpp

@@ -33,7 +33,7 @@ class AnalogSimpleSensor : public ::SenseShift::Input::IFloatSimpleSensor {
         pinMode(this->pin_, INPUT);
     }
 
-    [[nodiscard]] inline auto getValue() -> float override
+    inline auto getValue() -> float override
     {
         const std::uint16_t raw = analogRead(this->pin_);
         return static_cast<float>(raw) / ANALOG_MAX;

lib/arduino/senseshift/arduino/input/sensor/digital.hpp

@@ -21,7 +21,7 @@ class DigitalSimpleSensor : public ::SenseShift::Input::IBinarySimpleSensor {
         pinMode(this->pin_, this->mode_);
     }
 
-    [[nodiscard]] auto getValue() -> bool override
+    auto getValue() -> bool override
     {
         return digitalRead(this->pin_) == this->inverted_;
     }

lib/arduino_esp32/senseshift/arduino/output/ledc.hpp

@@ -41,7 +41,7 @@ class LedcOutput : public ::SenseShift::Output::IFloatOutput {
         }
     }
 
-    [[nodiscard]] inline auto getMaxValue() const -> std::uint32_t
+    inline auto getMaxValue() const -> std::uint32_t
     {
         return (1 << this->analog_resolution_) - 1;
     }

lib/battery/senseshift/battery/input/battery_sensor.hpp

@@ -44,7 +44,7 @@ class LookupTableInterpolateBatterySensor : public IBatterySensor {
     }
 
   protected:
-    [[nodiscard]] auto lookupInterpolateLevel(VoltageType voltage) -> float
+    auto lookupInterpolateLevel(VoltageType voltage) -> float
     {
         return ::SenseShift::lookup_table_interpolate_linear<Container, VoltageType, float>(
           *this->lookup_table_,

lib/core/senseshift/core/helpers.hpp

@@ -74,7 +74,7 @@ constexpr auto remap_simple(Up value, Up max, Tp max_out) noexcept -> Tp
 ///
 /// \return
 template<typename Container, typename Tp = typename Container::key_type, typename To = typename Container::mapped_type>
-[[nodiscard]] constexpr auto lookup_table_interpolate_linear(Container const& lookup_table, Tp value) -> To
+constexpr auto lookup_table_interpolate_linear(Container const& lookup_table, Tp value) -> To
 {
     static_assert(std::is_same_v<typename Container::key_type, Tp> && std::is_same_v<typename Container::mapped_type, To>);
     static_assert(
@@ -124,7 +124,8 @@ class CallbackManager<void(Ts...)> {
             callback(args...);
         }
     }
-    [[nodiscard]] auto size() const -> size_t
+
+    auto size() const -> size_t
     {
         return this->callbacks_.size();
     }

lib/haptics/senseshift/body/haptics/body.hpp

@@ -47,7 +47,7 @@ class OutputBody {
 
     void effect(const Target& target, const Position& pos, const typename Plane::Value& val);
 
-    [[nodiscard]] auto getTargets() const -> const TargetPlaneMap*
+    auto getTargets() const -> const TargetPlaneMap*
     {
         return &targets_;
     }

lib/haptics/senseshift/body/haptics/interface.hpp

@@ -68,7 +68,7 @@ class VibroEffectData {
         return this->intensity_;
     }
 
-    [[nodiscard]] constexpr inline auto getIntensity() const -> Intensity
+    constexpr inline auto getIntensity() const -> Intensity
     {
         return intensity_;
     }

lib/haptics/senseshift/body/haptics/plane.hpp

@@ -43,11 +43,12 @@ class OutputPlane {
     void setup();
     virtual void effect(const Position&, const Value&);
 
-    [[nodiscard]] auto getAvailablePoints() const -> const PositionSet*
+    auto getAvailablePoints() const -> const PositionSet*
     {
         return &points_;
     }
-    [[nodiscard]] auto getActuatorStates() const -> const PositionStateMap*
+
+    auto getActuatorStates() const -> const PositionStateMap*
     {
         return &states_;
     }
@@ -80,7 +81,7 @@ class OutputPlane_Closest : public OutputPlane<Tc, To> {
     void effect(const Position&, const Value&) override;
 
   private:
-    [[nodiscard]] static auto findClosestPoint(const PositionSet&, const Position&) -> const Position&;
+    static auto findClosestPoint(const PositionSet&, const Position&) -> const Position&;
 };
 
 using FloatPlane = OutputPlane<Position::Value, Output::IFloatOutput::ValueType>;

lib/io/senseshift/input/sensor.hpp

@@ -27,7 +27,7 @@ class ISimpleSensor : public virtual IInitializable {
     explicit ISimpleSensor() = default;
 
     /// Get the current sensor value.
-    [[nodiscard]] virtual auto getValue() -> ValueType = 0;
+    virtual auto getValue() -> ValueType = 0;
 };
 
 using IBinarySimpleSensor = ISimpleSensor<bool>;
@@ -86,20 +86,20 @@ class Sensor : public ISensor<Tp> {
     }
 
     /// Get the current sensor .value_.
-    [[nodiscard]] auto getValue() -> ValueType override
+    auto getValue() -> ValueType override
     {
         return this->value_;
     }
 
     /// Get the current raw sensor .raw_value_.
-    [[nodiscard]] auto getRawValue() -> ValueType
+    auto getRawValue() -> ValueType
     {
         return this->raw_value_;
     }
 
   protected:
     /// Apply current filters to value.
-    [[nodiscard]] auto applyFilters(ValueType value) -> ValueType
+    auto applyFilters(ValueType value) -> ValueType
     {
         /// Apply calibration
         if (this->getCalibrator() != nullptr) {

lib/opengloves/senseshift/opengloves/autoconfig.hpp

@@ -262,7 +262,7 @@
 
 namespace SenseShift::OpenGloves::AutoConfig {
 
-[[nodiscard]] auto createInput() -> InputSensors
+auto createInput() -> InputSensors
 {
     InputSensors input_sensors;
 
@@ -406,7 +406,7 @@ namespace SenseShift::OpenGloves::AutoConfig {
     return input_sensors;
 }
 
-[[nodiscard]] auto createFfbOutputs() -> OutputWriters
+auto createFfbOutputs() -> OutputWriters
 {
     OutputWriters output_writers;
 
@@ -441,7 +441,7 @@ namespace SenseShift::OpenGloves::AutoConfig {
 /**
  * Setup the transport for the OpenGloves interface.
  */
-[[nodiscard]] auto createTransport() -> ITransport*
+auto createTransport() -> ITransport*
 {
 #if OPENGLOVES_COMMUNICATION == OPENGLOVES_COMM_SERIAL // Serial
     auto* pSerial = &SERIAL_PORT;

lib/opengloves/senseshift/opengloves/opengloves.hpp

@@ -134,12 +134,12 @@ class InputSensors : public og::InputPeripheral<FloatSensor*, BinarySensor*> {
         }
     }
 
-    [[nodiscard]] auto collectData() -> og::InputPeripheralData
+    auto collectData() -> og::InputPeripheralData
     {
         SS_OG_COLLECT_DATA(getValue);
     }
 
-    [[nodiscard]] auto collectRawData() -> og::InputPeripheralData
+    auto collectRawData() -> og::InputPeripheralData
     {
         SS_OG_COLLECT_DATA(getRawValue);
     }