Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sps30 to newBox form #459

Merged
merged 4 commits into from
Feb 7, 2023
Merged

added sps30 to newBox form #459

merged 4 commits into from
Feb 7, 2023

Conversation

Thiemann96
Copy link
Contributor

Fix or Enhancement and description?

Added the option to add SPS30 to the home setup at the registration of a new box.

Environment

  • OS: Windows11
  • Browser & Version: Firefox

@Thiemann96
Copy link
Contributor Author

will do lint and stuff tomorrow, nothing to see here just yet

@Thiemann96 Thiemann96 requested a review from mpfeil December 15, 2022 16:31
mpfeil
mpfeil requested changes Dec 16, 2022
View reviewed changes
Copy link
Member

@mpfeil mpfeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the new sensor to the senseBox:edu hardware setup section

Thiemann96
Thiemann96 commented Jan 31, 2023
View reviewed changes
Copy link
Contributor Author

@Thiemann96 Thiemann96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in 55e7728

@mpfeil
Copy link
Member

mpfeil commented Feb 7, 2023

Nice update. @Thiemann96 one last thing. Could you check out the conflicts within the package-lock.json

@mpfeil mpfeil merged commit ed38ec5 into master Feb 7, 2023
@mpfeil mpfeil deleted the add_sps30_eric branch February 7, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpfeil mpfeil mpfeil requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thiemann96 @mpfeil