Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Attributes #12

Closed
AleAltube opened this issue Nov 17, 2018 · 15 comments
Closed

Additional Attributes #12

AleAltube opened this issue Nov 17, 2018 · 15 comments

Comments

@AleAltube
Copy link

Hi, first, thanks so much for making this code available!

Secondly, I’ve been struggling to add other attributes like user accounts’ “info”, the pivot tables don’t seem to like that... would it be possible to understand which lines would have to be modified to include other attributes for computer, group, and user objects without affecting any other part of the script?

Thanks again!

@prashant3535
Copy link
Contributor

Hi,

Could you please share the attributes you are trying to add or the provide more information about the pivot table issue? I can easily add those attributes and push a commit to the repo.

If the problem is only with the pivot table, then the Get-ADRExcelPivotTable function (https://github.com/sense-of-security/ADRecon/blob/master/ADRecon.ps1#L3886) is where the issue might be. For the User and Computer Stats sheet in the excel, the Get-ADRExcelAttributeStats function (https://github.com/sense-of-security/ADRecon/blob/master/ADRecon.ps1#L4030).

@AleAltube
Copy link
Author

Hey Prashant, is it feasible to have the mentioned attributes added? Can I help in any way?

@prashant3535
Copy link
Contributor

Hi AleAltube,

It is feasible to add the attributes. Some attributes are already present as renamed as you already know. I'm working on something else at the moment and should be able to get to it over the weekend.

Thanks for your patience.

@prashant3535
Copy link
Contributor

prashant3535 commented Dec 2, 2018

Hi AleAltude,

I've added the attributes as described below:

User Attributes:
[C] - Added as renamed field "Country"
[cn] - Already present as renamed field "Name"
[company] - Added
[givenName] - Added as renamed field "First Name"
[info] - Added
[sn] - Added as renamed field "Last Name"
[UserAccountControl] - Added
[sAMAccountName] - Already present as renamed field "UserName"

Added other attributes such as Department, Title, Manager, Mobile, etc.

TODO
[adDomain] -> This would have to be customized since it's not a native attribute (Optional)
[adForest] -> This would have to be customized since it's not a native attribute (Optional)

Computer Attributes:
[operatingSystemServicePack] - Already present as an Concatenated field "Operating System"
[operatingSystemType] - Already present as an Concatenated field "Operating System"
[operatingSystemVersion] - Already present as an Concatenated field "Operating System"
[sAMAccountName] (I think there is already a renamed attribute containing this value, but if possible it would be great if it can be added with its original attribute name as well) - Already present as renamed field "UserName"
[userAccountControl] - Added
TODO
[accountExpires]
[canonicalName]
[displayName]
[adDomain] -> This would have to be customized since it's not a native attribute (Optional)
[adForest] -> This would have to be customized since it's not a native attribute (Optional)

Group Attributes:
[samaccountname] (I think there is already a renamed attribute containing this value, but if possible it would be great if it can be added with its original attribute name as well) - Already present as renamed field "Name"
TODO
[adForest] -> This would have to be customized since it's not a native attribute (Optional)
[adDomain] -> This would have to be customized since it's not a native attribute (Optional)

@AleAltube
Copy link
Author

AleAltube commented Dec 2, 2018 via email

@AleAltube
Copy link
Author

AleAltube commented Dec 3, 2018 via email

prashant3535 added a commit that referenced this issue Dec 3, 2018
@prashant3535
Copy link
Contributor

Hi AleAltube,

Could you please try now ? Also, could you test it with -Protocol LDAP ? Thanks

@prashant3535
Copy link
Contributor

Lemme see if I can replicate it. Which version of powershell and office are you using ?

@prashant3535
Copy link
Contributor

Do you have any entry in the ComputerSPNs.csv file with a very long value in the Host column ?

@AleAltube
Copy link
Author

AleAltube commented Dec 4, 2018 via email

@prashant3535
Copy link
Contributor

Yes, that is the issue (too long info field). Let me see how I can solve it.

@AleAltube
Copy link
Author

AleAltube commented Dec 4, 2018 via email

prashant3535 added a commit that referenced this issue Dec 5, 2018
@AleAltube
Copy link
Author

AleAltube commented Dec 12, 2018 via email

@prashant3535
Copy link
Contributor

Hey AleAltube,

I pushed a potential bug fix for it last week. Are you still having the same issue ?

@AleAltube
Copy link
Author

AleAltube commented Dec 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants