Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add generation field to create template call otherwise legacy template will be created #907

Merged
merged 2 commits into from
Jun 24, 2020
Merged

docs: Add generation field to create template call otherwise legacy template will be created #907

merged 2 commits into from
Jun 24, 2020

Conversation

vinu-phoenix
Copy link
Contributor

I've added a generation field to the create template call otherwise it creates a legacy template by default

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 17, 2019
@SendGridDX
Copy link
Collaborator

SendGridDX commented Mar 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dvora-worthy
Copy link

dvora-worthy commented Nov 21, 2019 •
edited
Loading

@vinu-phoenix
even though I add the generation field to the request parameters, the template has been created as a lagacy template.

Can I do something to override the default behavior?

@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino changed the title Add generation field to create template call docs: Add generation field to create template call Jun 24, 2020
childish-sambino
childish-sambino approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino changed the title docs: Add generation field to create template call docs: Add generation field to create template call otherwise legacy template will be created Jun 24, 2020
@childish-sambino childish-sambino merged commit 4c3962e into sendgrid:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinu-phoenix @SendGridDX @dvora-worthy @childish-sambino @thinkingserious