Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

Set up a docker container #59

Closed
mbernier opened this issue Oct 29, 2017 · 0 comments · Fixed by #63
Closed

Set up a docker container #59

mbernier opened this issue Oct 29, 2017 · 0 comments · Fixed by #63
Labels
hacktoberfest help wanted up-for-grabs

Comments

@mbernier
Copy link
Contributor

Issue Summary

Use docker-compose to build a container that:

  • upon running, it executes all tests
  • it uses a local volume in docker-compose to allow caching of node_modules and local code edits to make changes in the container
onefastsnail added a commit to onefastsnail/nodejs-http-client that referenced this issue Oct 29, 2017
@onefastsnail
Working sendgrid#59 by adding a docker-compose file to spin up a cont…
4265e2e 
…ainer from which we can run tests through. Commented out related tests from sendgrid#60 so tests would pass. Updated the readme with some instructions.
onefastsnail added a commit to onefastsnail/nodejs-http-client that referenced this issue Oct 29, 2017
@onefastsnail
Closing sendgrid#59 by adding a docker-compose file to spin up a cont…
3e756e4 
…ainer from which we can run tests through. Commented out related tests from sendgrid#60 so tests would pass until such files are created. Updated the readme with some instructions.
@onefastsnail onefastsnail mentioned this issue Oct 29, 2017
Merged
6 tasks
mbernier pushed a commit that referenced this issue Nov 22, 2017
Merge pull request #63 from onefastsnail/docker-tests
758241f 
Closes #59 by adding a docker-compose file to spin up a container fr…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
hacktoberfest help wanted up-for-grabs
Projects
None yet
Milestone
No milestone
1 participant
@mbernier