Fix Patient Medical Record must be unique error when MRN has leading/traling whitespaces #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request fixes a ValueError that arises when trying to create samples or partitions from another sample (either by copying or referred as primary) that has a MRN assigned with leading or trailing whitespaces, and for which a Patient was created earlier via Add sample's form temporary widget.
This is necessary because when creating a Patient object, while the MRN was automatically stripped in
setMRNfunction, its value in AnalysisRequest was left without changes, leading to inconsistencies.Current behavior before PR
ValueError: Patient Medical Record Number must be uniqueerror when creating partitions from an existing sampleDesired behavior after PR is merged
Partitions are created without error, while MRN is kept.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.