Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot create partitions from samples with Patient assigned #65

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Fix cannot create partitions from samples with Patient assigned #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9acbd2b
Fix cannot create partitions from samples with Patient assigned
xispa Mar 11, 2023
16286b3
Changelog
xispa Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Changelog
1.4.0 (unreleased)
------------------

- #65 Fix cannot create partitions from samples with Patient assigned
- #64 Fix samples without patient middle name
- #63 Fix Traceback in patient's samples view when name has special characters
- #62 Added new name entry mode (firstname + lastname)
Expand Down
6 changes: 6 additions & 0 deletions src/senaite/patient/browser/widgets/temporaryidentifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ def process_form(self, instance, field, form, empty_marker=None,
if not identifier:
return None, {}

# The value might be a dict with the temporary id info already
if isinstance(identifier, dict):
temporary = identifier.get("temporary", temporary)
autogenerated = identifier.get("value_auto", autogenerated)
identifier = identifier.get("value") or None

# The ID might need to be auto-generated if temporary?
if temporary and identifier in [None, AUTO_ID_MARKER]:
kwargs = {"portal_type": field.getName()}
Expand Down