Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional MRN in Patient Add/Edit forms #55

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR makes the Patient MRN field optional in Add/Edit forms, if it is not set to mandatory in Patient setup:

Current behavior before PR

MRN was always required

Desired behavior after PR is merged

MRN is not required if not set as mandatory in patient setup

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added the enhancement New feature or request label Oct 17, 2022
@ramonski ramonski requested a review from xispa October 17, 2022 20:53
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Just a really minor thing. Would you mind to change the description of the setting "Require Medical Record Number (MRN)" to something like "Make the MRN field mandatory in Sample Add form and on patient creation/edition"?

Thanks!

@ramonski
Copy link
Contributor Author

Description changed in 2c5603b

@xispa xispa merged commit c398204 into master Oct 18, 2022
@xispa xispa deleted the require-mrn-optional branch October 18, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants