Add patient marital status #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Oct 12, 2022
src/senaite/patient/vocabularies.py
Outdated
| # value, token, title | ||
| term = SimpleTerm(keyword, keyword, title) | ||
| items.append(term) | ||
| return SimpleVocabulary(sorted(items, key=lambda t: t.title)) |
There was a problem hiding this comment.
I think is better to remove this sorting, the "Up"/"Down" buttons from the records field (by means of the allow_reorder parameter) do not longer make sense otherwise:
There was a problem hiding this comment.
Ah, you are right!
We are sorting the vocabulary by title at the moment and overriding the manual sort order therefore.
Shall we just just drop the sorting in the vocabulary instead?
There was a problem hiding this comment.
Shall we just just drop the sorting in the vocabulary instead?
Yes please
There was a problem hiding this comment.
Ok, I removed the alphabetical sorting now for all vocabularies and allow instead manual reordering of the items.
xispa
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR adds a new field to track the patient marital status:
The default available marital statuses are defined according to http://hl7.org/fhir/R4/valueset-marital-status.html
This list can be modified in the patient control panel:
Current behavior before PR
Marital status not tracked for patients
Desired behavior after PR is merged
Marital status is tracked for patients
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.