Support context aware report controller views #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
At the moment the report controller view is a multi-adapter for
model/collection
and therequest
.The rendering context within the view (
self.context
) is hard coded to the portal object.This PR allows to register a context aware multi-adapter for the current rendering
context
, themodel/collection
and therequest
.The registration in
configure.zcml
can be done like this:With this corresponding report controller view implementation:
Any context aware multi-adapter takes precedence over the multi-adapters that only adapt the
model/controller
and therequest
Current behavior before PR
No context aware report controller views supported
Desired behavior after PR is merged
Context aware report controller views supported
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.