Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend 'Reports in external packages' section of README #73

Merged
merged 2 commits into from
May 21, 2019

Conversation

mikejmets
Copy link
Contributor

Description of the issue/feature this PR addresses

Added more details to the 'Reports in external packages' section of the READ

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mike, thanks for adding this.
Only two small things to change, then I can merge it

README.md Outdated
def __init__(self, collection, request):
logger.info("MyMultiReportView::__init__:collection={}"
.format(collection))
super(MyMultiReportView, self).__init__(collection, re
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the missing part here

README.md Outdated
"""
```

And a `browserlayer.xml`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the location here, e.g. profiles/default/browserlayer.xml

Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ramonski ramonski merged commit f3168f2 into master May 21, 2019
@xispa xispa deleted the readme_additions branch May 22, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants