Better Nambooripad #1026
Merged
Better Nambooripad #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @Tianrun-Y, can you please give an example which indicates why we should prefer the new method over the older method? |
|
Old version New version |
|
Can you please add the example to the relevant test file? Then I'll be happy to merge, and thanks very much! |
Test added with time included as a comment. Hope this is good? |
james-d-mitchell
approved these changes
Nov 8, 2024
JosephDayngerRuiz
pushed a commit
to JosephDayngerRuiz/Semigroups
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A faster way of finding the Nambooripad Partial Order (aka natural partial order and Mitsch order) of a finite regular semigroup.