Merge pull request #91 from appliedzkp/fix/group-id-value

Fix/group id value
semaphore-protocol · Mar 9, 2022 · aacbb11 · aacbb11
2 parents 8022e4b + 5d8243c
commit aacbb11
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/contracts/base/SemaphoreGroups.sol b/contracts/base/SemaphoreGroups.sol
@@ -29,6 +29,7 @@ abstract contract SemaphoreGroups is Context, ISemaphoreGroups {
     uint8 depth,
     uint256 zeroValue
   ) internal virtual {
+    require(groupId < SNARK_SCALAR_FIELD, "SemaphoreGroups: group id must be < SNARK_SCALAR_FIELD");
     require(getDepth(groupId) == 0, "SemaphoreGroups: group already exists");
 
     groups[groupId].init(depth, zeroValue);

diff --git a/contracts/package.json b/contracts/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@appliedzkp/semaphore-contracts",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "A privacy gadget for creating anonymous proof of membership on Ethereum.",
   "license": "GPL-3.0",
   "files": [

diff --git a/test/SemaphoreVoting.ts b/test/SemaphoreVoting.ts
@@ -30,6 +30,16 @@ describe("SemaphoreVoting", () => {
       await expect(transaction).to.be.revertedWith("SemaphoreVoting: depth value is not supported")
     })
 
+    it("Should not create a poll greater than the snark scalar field", async () => {
+      const transaction = contract.createPoll(
+        BigInt("21888242871839275222246405745257275088548364400416034343698204186575808495618"),
+        coordinator,
+        depth
+      )
+
+      await expect(transaction).to.be.revertedWith("SemaphoreGroups: group id must be < SNARK_SCALAR_FIELD")
+    })
+
     it("Should create a poll", async () => {
       const transaction = contract.createPoll(pollIds[0], coordinator, depth)
 

diff --git a/test/SemaphoreWhistleblowing.ts b/test/SemaphoreWhistleblowing.ts
@@ -28,6 +28,16 @@ describe("SemaphoreWhistleblowing", () => {
       await expect(transaction).to.be.revertedWith("SemaphoreWhistleblowing: depth value is not supported")
     })
 
+    it("Should not create an entity greater than the snark scalar field", async () => {
+      const transaction = contract.createEntity(
+        BigInt("21888242871839275222246405745257275088548364400416034343698204186575808495618"),
+        editor,
+        depth
+      )
+
+      await expect(transaction).to.be.revertedWith("SemaphoreGroups: group id must be < SNARK_SCALAR_FIELD")
+    })
+
     it("Should create an entity", async () => {
       const transaction = contract.createEntity(entityIds[0], editor, depth)