Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 372 text datatype properties #989

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Issue 372 text datatype properties #989

merged 9 commits into from
Nov 7, 2023

Conversation

uscholdm
Copy link
Contributor

Fixes #372

  • Deprecated tagText, to be replaced by containedText.
  • containedText
    • Added domainIncludes Tag and Text
    • Removed reference to Text class in the definition
    • Added examples

@uscholdm uscholdm requested a review from rjyounes October 26, 2023 00:17
@uscholdm uscholdm mentioned this pull request Oct 26, 2023
Closed
rjyounes
rjyounes requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this PR should not include the deprecation. Please add it as a new issue for triage.

@uscholdm
Copy link
Contributor Author

As discussed, this PR should not include the deprecation. Please add it as a new issue for triage.

That is not my understanding. This deprecation signals that the property will be removed on next major release. It is a minor update with instructions for what to do on the release (here). I think it's ok as it is.

@uscholdm uscholdm requested a review from rjyounes October 30, 2023 14:24
@rjyounes rjyounes merged commit f340343 into develop Nov 7, 2023
@rjyounes rjyounes deleted the issue-372-text-datatype-properties branch November 7, 2023 22:52
@rjyounes rjyounes mentioned this pull request Nov 8, 2023
Open
@uscholdm uscholdm mentioned this pull request Nov 15, 2023
Closed
@uscholdm uscholdm mentioned this pull request Sep 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjyounes rjyounes rjyounes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
gist Version 12.1.0
Status: Done
Milestone
No milestone
2 participants
@uscholdm @rjyounes