Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify restrictions on OrderedMember. Fixes #574. #573

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

rjyounes
Copy link
Collaborator

@rjyounes rjyounes commented Sep 16, 2021

Change:

owl:unionOf (
	[
		a owl:Restriction ;
		owl:onProperty gist:precedesDirectly ;
		owl:someValuesFrom gist:Thing ;
	]
	[
		a owl:Restriction ;
		owl:onProperty gist:followsDirectly ;
		owl:someValuesFrom gist:Thing ;
	]
	[
		a owl:Restriction ;
		owl:onProperty gist:sequence ;
		owl:someValuesFrom xsd:integer ;
	]
) ;

to


owl:unionOf (
	[
		a owl:Restriction ;
		owl:onProperty gist:precedesDirectly ;
		owl:someValuesFrom gist:OrderedMember ;
	]
	[
		a owl:Restriction ;
		owl:onProperty gist:followsDirectly ;
		owl:someValuesFrom gist:OrderedMember ;
	]
	[
		a owl:Restriction ;
		owl:onProperty gist:sequence ;
		owl:someValuesFrom xsd:integer ;
	]
) ;

This change clarifies the meaning of the restriction, though it is strictly speaking logically redundant: since only OrderedMembers belong to OrderedCollections, precedence would be only in relation to other OrderedMembers. There's an edge case counterexample where an OrderedMember is asserted to precede or follow something outside the OrderedCollection, but it's hard to see how that situation would occur. At any rate, this creates greater clarity.

@rjyounes rjyounes added the impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) label Sep 16, 2021
@rjyounes rjyounes merged commit fcb0cbd into develop Sep 17, 2021
@rjyounes rjyounes deleted the feature/OrderedMember_restrictions branch September 17, 2021 20:34
@rjyounes rjyounes changed the title Clarify restrictions on OrderedMember Clarify restrictions on OrderedMember. Fixes #574. Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants