-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing multiple issues for v10.0.0. Fixes #126, #136, #171, #174. #503
Conversation
- Renamed decimalValue to numericValue - Changes to Person, including name and hasBirthDate - Refactored network connections, renaming properties and tightening up their definition - Clarified definition of ContemporaneousEvent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've proposed some annotation changes, although they aren't included in the decisions made on the issues, because I always scan these and make corrections when I'm working on a term. I find the current network-related ones quite confusing; and in fact I believe were the source of our confusion about how these terms should be used.
Everything else looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gist:numericValue looks good.
One comment below that can be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for one missing period. I do not need to re-review after it's added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current versions (on github, but not showing up on this web page) look fine, but for one small thing. Replace Unlike the superproperty, links,
with Unlike its superproperty, links,
If you strongly object with having links
mentioned, I won't be that bothered. I like it because it saves having to look at the code, which is kind of the point of a definition.
@sa-bpelakh Need to resolve conflicts in release notes. |
…eanup-126-136-171-174
decimalValue
tonumericValue
Person
, includingname
andhasBirthDate
ContemporaneousEvent
Tagging @Jamie-SA for
numericValue
, the usual suspects for the rest.