Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hasPhysicalLocation transitive (Fixes #109) #353

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Make hasPhysicalLocation transitive (Fixes #109) #353

merged 1 commit into from
Aug 28, 2020

Conversation

marksem
Copy link
Collaborator

@marksem marksem commented Aug 28, 2020

No description provided.

@marksem marksem requested a review from rjyounes August 28, 2020 14:28
rjyounes
rjyounes approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Just as a matter of style, do we always want to assert both ObjectProperty and TransitiveProperty types, or can we leave the former as entailed by the latter? I don't have strong feelings, just posing the question.

@rjyounes rjyounes merged commit d697a58 into develop Aug 28, 2020
@rjyounes rjyounes deleted the bugfix/hasPhysicalLocation-should-be-transitive branch August 28, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjyounes rjyounes rjyounes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marksem @rjyounes