Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove occupies predicates and shorten isGeographicallyContainedIn #1085

Merged
merged 8 commits into from
May 29, 2024
Merged
14 changes: 11 additions & 3 deletions docs/gistStyleGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- [Labels](#labels)
- [Classes](#classes)
- [Properties](#properties)
- [Valid Exceptions](#valid-exceptions)
- [gist Definition of Title Case](#gist-definition-of-title-case)
- [Annotations](#annotations)
- [Conventions for Use](#conventions-for-use)
Expand Down Expand Up @@ -80,7 +81,7 @@ Some of the examples resulted in changes to gist `10.0.0`, others are hypothetic
|| `usesTimeZoneStandard`, not `timeZoneStandardUsed` |
| Prefix "is" to "-ed" forms, both past participles and adjectives | `isGovernedBy`, not `governedBy` |
|| `isCharacterizedBy`, not `characterizedBy` |
| Prefer an ordinary verb to "hasX" or "isX", even in a pair of inverses | `follows`, not `isPrecededBy`, even when inverse `precedes` exists |
| Prefer an ordinary verb to "hasX" or "isX" | `precedes`, not `isFollowedBy` |
| "At" rather than "on" for datetimes | `isRecordedAt`, not `isRecordedOn`. |
| Present tense only with minimal exceptions when the meaning is inherently in the past | `isRenderedOn`, not `wasRenderedOn`, but `wasLastModifiedBy` rather than `isLastModifiedBy` |
|| `precedes`, not `preceded` |
Expand Down Expand Up @@ -118,7 +119,7 @@ Note: As of version 12.0.0, gist itself does not itself follow the infix convent

## Labels

*The* following conventions apply to `skos:prefLabel` but *not* `skos:altLabel`.
The following conventions apply to `skos:prefLabel` but *not* `skos:altLabel`, which by nature may be idiosyncratic.

### Classes

Expand All @@ -130,7 +131,14 @@ Note: As of version 12.0.0, gist itself does not itself follow the infix convent

- Lower case
- Normalized to natural language standards. E.g., hyphens inserted, acronyms in all caps, proper nouns capitalized, etc.
- Examples: *has unit of measure*, *has SSN*, *unit symbol Unicode*
- Examples: *has unit of measure*, *has SSN*

### Valid Exceptions

There may occasionally be valid reasons to deviate from the conventions stated here:

- Deviation from wording of the local name. For example, the predicate `gist:isGeoContainedIn` uses a shortened form of "geographically" for conciseness. The `skos:prefLabel` uses the fully spelled out word: "is geographically contained in."
- Deviation from typographical conventions such as case. For example, a proper name in a property label could appropriately be capitalized. Since this will fail the SHACL validation constraints during the ontology build and release process, add the term to the `gistValidationAnnotations.ttl` file so that label validation will be skipped.

### gist Definition of Title Case

Expand Down
8 changes: 8 additions & 0 deletions docs/release_notes/issue812-geo-predicates
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
### Major Updates

- Removed `gist:occupiesGeographically` and `gist:occupiesGeographicallyPermanently`, and replaced with `gist:hasPhysicalLocation` in class restriction. Issue [#809](https://github.com/semanticarts/gist/issues/809).
- Shortened local name of `gist:isGeographicallyContainedin` to `isGeoContainedin`. Issue [#812](https://github.com/semanticarts/gist/issues/812).

### Patch Updates

- Added notes on exceptions to `skos:prefLabel` formatting conventions to [gist Style Guide](#gistStyleGuide.md).
31 changes: 4 additions & 27 deletions ontologies/gistCore.ttl
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,7 @@ gist:GeoVolume
[
a owl:Restriction ;
owl:onProperty [
owl:inverseOf gist:isGeographicallyContainedIn ;
owl:inverseOf gist:isGeoContainedIn ;
] ;
owl:someValuesFrom gist:GeoPoint ;
]
Expand Down Expand Up @@ -1294,7 +1294,7 @@ gist:Landmark
gist:PhysicalIdentifiableItem
[
a owl:Restriction ;
owl:onProperty gist:occupiesGeographicallyPermanently ;
owl:onProperty gist:hasPhysicalLocation ;
owl:someValuesFrom [
a owl:Class ;
owl:unionOf (
Expand Down Expand Up @@ -3436,14 +3436,14 @@ gist:isExpressedIn
skos:prefLabel "is expressed in"^^xsd:string ;
.

gist:isGeographicallyContainedIn
gist:isGeoContainedIn
a
owl:ObjectProperty ,
owl:TransitiveProperty
;
rdfs:domain gist:Place ;
rdfs:range gist:Place ;
skos:definition "Relates one place to another place that contains the first."^^xsd:string ;
skos:definition "Relates one place to another that contains it."^^xsd:string ;
skos:prefLabel "is geographically contained in"^^xsd:string ;
.

Expand Down Expand Up @@ -3633,29 +3633,6 @@ gist:numericValue
skos:prefLabel "numeric value"^^xsd:string ;
.

gist:occupiesGeographically
a owl:ObjectProperty ;
rdfs:domain [
a owl:Class ;
owl:unionOf (
gist:PhysicalIdentifiableItem
gist:PhysicalSubstance
) ;
] ;
rdfs:range gist:Place ;
owl:deprecated "true"^^xsd:boolean ;
skos:definition "A thing occupies are region"^^xsd:string ;
skos:prefLabel "occupies geographically"^^xsd:string ;
.

gist:occupiesGeographicallyPermanently
a owl:ObjectProperty ;
rdfs:subPropertyOf gist:occupiesGeographically ;
owl:deprecated "true"^^xsd:boolean ;
skos:definition "To be in a fixed position on the earth"^^xsd:string ;
skos:prefLabel "occupies geographically permanently"^^xsd:string ;
.

gist:occursIn
a owl:ObjectProperty ;
skos:definition "The geospatial place where something happened or will happen"^^xsd:string ;
Expand Down
Loading