Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix definition of gist:SimpleUnitOfMeasure #84

Closed
rjyounes opened this issue Aug 1, 2019 · 0 comments
Closed

Fix definition of gist:SimpleUnitOfMeasure #84

rjyounes opened this issue Aug 1, 2019 · 0 comments
Assignees
@rjyounes
Labels
effort: small Requires less than one day to complete impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: implementation specified Implementation has been specified. A developer should be assigned.

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Aug 1, 2019

The definition currently reads:

Each simple unit has a base unit and a conversion factor to the base. The bases are from the System International (SI). This is the number by which one multiplies a Unit by to get to base, or divides by to get from base.  So the convertToBase for inch is 0.0254 to get you to the base (meter).

  1. There is a minor typo in sentence 3: an extra "by."

  2. If "this is the number" refers to the convertToBase value, that should be explicit. Currently it's a bit confusing.

Proposed rewrite:

Each simple unit has a base unit and a conversion factor to the base. The bases are from the System International (SI). The conversion factor is the number that one multiplies by to get to base, or divides by to get from base.  So the convertToBase for inch is 0.0254 to get to the base (meter).
@stewardont stewardont mentioned this issue Jan 16, 2020
Closed
@rjyounes rjyounes self-assigned this Apr 23, 2020
@rjyounes rjyounes added effort: small Requires less than one day to complete impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: implementation specified Implementation has been specified. A developer should be assigned. status: triaged labels Apr 23, 2020
sa-bpelakh added a commit that referenced this issue Apr 24, 2020
@sa-bpelakh
Add resolution of #84 to ReleaseNotes.
0376c9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjyounes rjyounes

Labels
effort: small Requires less than one day to complete impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: implementation specified Implementation has been specified. A developer should be assigned.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjyounes