-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remodel times to use datatype properties rather than TimeInstant #499
Comments
Adding to July 2021 project in order to consider postponing release of 10.0.0 to include these changes. |
See description of #470: As currently constituted (v9.7), gist provides no way to assert a start or stop time directly. It all relies on the use of TimeInstant instances, which can be cumbersome, hard to mint in a standard fashion, and not always necessary.
If adopted, some class restrictions should be rewritten to include the use of these in addition to the TimeInstant-dependent properties. |
In the scope of this proposal, consider all issues labeled |
See Dave's slides attached to the description for the implementation details. A couple of predicate name changes:
Also consider the new predicate names in version |
Which is it, microsecond or millisecond? I thought the latter. |
Yeah, I wondered, but system time uses microseconds (I think - someone else should confirm or disconfirm). How about nanoseconds? :) |
But you have both in the above example. Pick one. |
I see. I've fixed it above. |
The spec says this about seconds: "secondFrag is a numeral consisting of exactly two decimal digits, or two decimal digits, a decimal point, and one or more trailing digits" That seems to say to me that it is neither microseconds or milliseconds. It is a fractional second to an arbitrary precision. |
Then we need to call it "SystemTime" as Dave originally had it. |
Do we have the final recommendation posted somewhere? Or a PR with the changes? |
Dan sent me an early draft, I switched the namespace to gist and corrected a couple of the more egregious errors. I changed dateTimeStatmp to dateeTime, as the spec says there are two differences, one dateTime is one of the primitives (therefore I’m hoping more widespread use by query engines) and the only difference is that Stamp requires a timezone offset
On Dec 8, 2021, at 10:15 AM, Jamie-SA ***@***.******@***.***>> wrote:
Do we have the final recommendation posted somewhere? Or a PR with the changes?
I'd like to start using the new terms on a project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#499 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAGJPWOX2IR523OIP6FF43UP6HEZANCNFSM47QXB2YA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
My recollection is that Dave presented a suggested a major reworking of how we do dates and times. I remember thinking it was very workable and I don't recall a lot of push back. But I also do not recall any overt consensus to move forward with the idea. So I'd be a bit surprised if someone went ahead and did the work with a PR awaiting review. |
@uscholdm Looks like you're correct. We need to discuss this further, once we've conquered countries and governments. @DanCarey404 If you agree with this, you could hold off on submitting a PR. |
Hmmm, I thought we had reviewed this and were getting close to approving the set of dataproperties. There were a few small concerns still left. I hope we didn't lose ground by putting it off instead of just completing it when it was fresh on people's minds. |
Assigning Mark to perform any cleanup on Dave's time modifications and submit a PR. |
Proposal by @mkumba. Documents attached.
gistTime-apptx.pptx
experimentsWithDateDatatypes.ttl.txt
The text was updated successfully, but these errors were encountered: