-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename Visual Studio Team Services
to Azure Pipelines
#135
Conversation
Hi @pvdlg 👋🏼 I've been having to work with Azure DevOps in a new role. Not being familiar with ADO previously, I wasn't aware that it was a branding change from VSTS. Therefore, it took me a bit to realize that Azure DevOps was included in the supported CI list. Hoping this makes it more obvious for someone in the future. I did notice that none of the other service names used a |
@travi shall we apply the change with the next breaking release? |
works for me. however, this seems separate enough from the switch to ESM that i wonder if we should release this separately/before the ESM changes |
what thoughts do you have around naming conventions used in this change? i was a bit on the fence around what i went with and i wonder if #156 (comment) sets a new precedent that should be followed with this change |
good point, I don't mind at all
could catch! We should probably document the service naming conventions in the README and in a comment above the export in |
e56441a
to
19a9c62
Compare
i updated to follow the convention set in the cloudflare pages PR. i think having multiple examples makes the convention clear enough without a comment, but you could convince me that it is worth adding one. previously, there just wasnt an example to follow since all services had simple names. |
Visual Studio Team Services
to Azure DevOps
Visual Studio Team Services
to Azure Pipelines
since the service itself was rebranded: https://azure.microsoft.com/en-us/blog/introducing-azure-devops/ BREAKING CHANGE: the `vsts` service name is now `azurePipelines`
yeah I think we should be good. Time will tell, it's a problem when it's a problem. Do you want to go ahead and release v6 without the ESM transition? Feel free to do so |
yeah, i think it makes sense to make this available ahead of the esm transition so that folks arent blocked migrating to use is by other details that might block them from transitioning to consuming an esm-only package |
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
since the service itself was rebranded:
https://azure.microsoft.com/en-us/blog/introducing-azure-devops/
BREAKING CHANGE: the
vsts
service name is nowazurePipelines