Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Visual Studio Team Services to Azure Pipelines #135

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

travi
Copy link
Member

@travi travi commented Oct 9, 2020

since the service itself was rebranded:
https://azure.microsoft.com/en-us/blog/introducing-azure-devops/

BREAKING CHANGE: the vsts service name is now azurePipelines

@travi
Copy link
Member Author

travi commented Oct 9, 2020

Hi @pvdlg 👋🏼

I've been having to work with Azure DevOps in a new role. Not being familiar with ADO previously, I wasn't aware that it was a branding change from VSTS. Therefore, it took me a bit to realize that Azure DevOps was included in the supported CI list. Hoping this makes it more obvious for someone in the future.

I did notice that none of the other service names used a -, but it seemed appropriate here. If you'd prefer a simpler option, I'm happy to update.

@gr2m
Copy link
Member

gr2m commented Oct 18, 2021

@travi shall we apply the change with the next breaking release?

@gr2m gr2m added this to the v6.0.0 milestone Oct 18, 2021
@travi
Copy link
Member Author

travi commented Oct 28, 2021

shall we apply the change with the next breaking release?

works for me. however, this seems separate enough from the switch to ESM that i wonder if we should release this separately/before the ESM changes

@travi
Copy link
Member Author

travi commented Oct 28, 2021

what thoughts do you have around naming conventions used in this change? i was a bit on the fence around what i went with and i wonder if #156 (comment) sets a new precedent that should be followed with this change

@gr2m
Copy link
Member

gr2m commented Oct 29, 2021

works for me. however, this seems separate enough from the switch to ESM that i wonder if we should release this separately/before the ESM changes

good point, I don't mind at all

what thoughts do you have around naming conventions used in this change? i was a bit on the fence around what i went with and i wonder if #156 (comment) sets a new precedent that should be followed with this change

could catch! We should probably document the service naming conventions in the README and in a comment above the export in index.js?

@travi travi force-pushed the vsts-ado branch 2 times, most recently from e56441a to 19a9c62 Compare December 3, 2021 16:18
@travi
Copy link
Member Author

travi commented Dec 3, 2021

i updated to follow the convention set in the cloudflare pages PR. i think having multiple examples makes the convention clear enough without a comment, but you could convince me that it is worth adding one. previously, there just wasnt an example to follow since all services had simple names.

@travi travi requested a review from a team December 3, 2021 16:21
@travi travi changed the title rename Visual Studio Team Services to Azure DevOps rename Visual Studio Team Services to Azure Pipelines Dec 3, 2021
since the service itself was rebranded:
https://azure.microsoft.com/en-us/blog/introducing-azure-devops/

BREAKING CHANGE: the `vsts` service name is now `azurePipelines`
@gr2m
Copy link
Member

gr2m commented Dec 3, 2021

i think having multiple examples makes the convention clear enough without a comment

yeah I think we should be good. Time will tell, it's a problem when it's a problem.

Do you want to go ahead and release v6 without the ESM transition? Feel free to do so

@travi
Copy link
Member Author

travi commented Dec 3, 2021

Do you want to go ahead and release v6 without the ESM transition?

yeah, i think it makes sense to make this available ahead of the esm transition so that folks arent blocked migrating to use is by other details that might block them from transitioning to consuming an esm-only package

@travi travi merged commit f0fecdb into semantic-release:master Dec 3, 2021
@travi travi deleted the vsts-ado branch December 3, 2021 21:01
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants