Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: undefined variable used in logging call #158

Merged
merged 1 commit into from
May 30, 2024

Conversation

jdlangs
Copy link
Contributor

@jdlangs jdlangs commented May 30, 2024

Reference the issue numbers and reviewers
Bug introduced in PR #88 (@danisla)

Explain relevant issues and how this pull request solves them
It looks like the logging statement used when xfconf-query fails had been copied from set_dpi(dpi) for set_cursor_size(size) but the dpi variable was not changed. So when xfconf-query didn't work properly in my setup, it triggered an exception and crashed the program.

Describe the changes in code and its dependencies and justify that they work as intended after testing
After fixing the variable name, I confirmed there is no crash and a proper logging statement is generated letting me know xfconf-query failed.

  • I confirm that this pull request is relevant to the scope of this project. If you know that upstream projects are the cause of this problem, please file the pull request there.
  • I confirm that this pull request has been tested thoroughly and to the best of my knowledge that additional unintended problems do not arise.
  • I confirm that the style of the changed code conforms to the overall style of the project.
  • I confirm that I have read other open and closed pull requests and that duplicates do not exist.
  • I confirm that I have justified the need for this pull request and that the changes reflect the fix for the specified problem.
  • I confirm that no portion of this pull request contains credentials or other private information, and it is my own responsibility to protect my privacy.

@ehfd
Copy link
Member

ehfd commented May 30, 2024

Looks like this was the issue for #110 that everyone overlooked?

Thank you very much for your help. Now I understand that GM uses my project :).

@ehfd ehfd merged commit 2eed265 into selkies-project:main May 30, 2024
13 checks passed
@jdlangs jdlangs deleted the fix/logging-bug branch May 30, 2024 13:28
@jdlangs
Copy link
Contributor Author

jdlangs commented May 30, 2024

Thanks, we appreciate the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants