Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in hash5Tuple #1495

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix bugs in hash5Tuple #1495

merged 1 commit into from
Jul 19, 2024

Conversation

prudens
Copy link
Contributor

@prudens prudens commented Jul 12, 2024

Fixes #1447

  1. Add directionUnique condition.
  2. Use memcmp function to compare source and destination IPv6 addresses.

@prudens prudens requested a review from seladb as a code owner July 12, 2024 08:34
@seladb seladb changed the title Fixes Bug#1447 Fix bugs in hash5Tuple Jul 19, 2024
@seladb seladb merged commit a4a7e89 into seladb:dev Jul 19, 2024
38 checks passed
@seladb
Copy link
Owner

seladb commented Jul 19, 2024

Thank you @prudens for working on it, much appreciated! 🙏 ❤️

And sorry for the delay in reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Review: The functions 'hash5Tuple' and 'hash2Tuple' implemented incorrectly in PacketUtils.cpp.
2 participants