Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1450 #1493

Closed
wants to merge 3 commits into from
Closed

Fixes #1450 #1493

wants to merge 3 commits into from

Conversation

prudens
Copy link
Contributor

@prudens prudens commented Jul 9, 2024

Add check logic code to ensure that when the client sends both FIN and RST commands, the server can also immediately close, ensuring that the entire process is in a closed state.

@prudens prudens requested a review from seladb as a code owner July 9, 2024 04:48
@tigercosmos
Copy link
Collaborator

@prudens is there any reason that you merge two issue fixes together? might be better to split the PR into two, where each PR only targets one issue.

@prudens
Copy link
Contributor Author

prudens commented Jul 12, 2024

@tigercosmos
I am very sorry for the inconvenience, but I am not very familiar with the PR process. I submitted a PR on my forked branch, and subsequent commits were automatically merge into this PR. I don't know how to revert this.

@tigercosmos
Copy link
Collaborator

tigercosmos commented Jul 12, 2024

@tigercosmos I am very sorry for the inconvenience, but I am not very familiar with the PR process. I submitted a PR on my forked branch, and subsequent commits were automatically merge into this PR. I don't know how to revert this.

try to create a new branch from "master", and you can use git cherry-pick to pick the commits into the new branch. Ask ChatGPT for more information :)

@prudens prudens closed this by deleting the head repository Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The TcpReassembly class does not correctly handle the logic for closing connections with TCP RST commands.
2 participants