-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored clang version check into a python script. #1471
Merged
tigercosmos
merged 7 commits into
seladb:dev
from
Dimi1010:fix/clang-version-checker-win32
Jun 25, 2024
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
37de157
Refactored check-check-clang-format-version to a python script to fix…
Dimi1010 0cb52f8
Lint
Dimi1010 c0b4713
Changed exit codes to ValueError exception.
Dimi1010 c6efe07
Split subprocess arguments string.
Dimi1010 aabbbba
Explicitly call python3.
Dimi1010 4349193
Merge branch 'dev' into fix/clang-version-checker-win32
Dimi1010 de4d3d8
Changed string split to use default whitespace separators.
Dimi1010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import subprocess | ||
|
||
EXPECTED_CLANG_VERSION = "18.1.6" | ||
|
||
|
||
def main(): | ||
result = subprocess.run(("clang-format", "--version"), capture_output=True) | ||
result.check_returncode() | ||
|
||
version_str = result.stdout.decode("utf-8").split(" ")[2].strip() | ||
if version_str != EXPECTED_CLANG_VERSION: | ||
raise ValueError( | ||
f"Error: Found clang-format version {version_str}, but {EXPECTED_CLANG_VERSION} is required." | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the default split character is space, so you can just do:
.split()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated in de4d3d8