-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified allocation of heap buffer during gateway fetch on win32. #1402
Simplified allocation of heap buffer during gateway fetch on win32. #1402
Conversation
@Dimi1010 did you have a chance to test it on Windows? We don't have tests for it unfortunately because it's not easy to run it in CI... |
I see. Haven't tested it yet, thought it was part of the CI. Will test it after I fix the merge conflicts. |
I am curious about why it is impossible to run it on CI? |
…p-device-buffers # Conflicts: # Pcap++/src/PcapLiveDevice.cpp
@seladb Tested it on Win10, using local adapter. All tests passed, except |
@Dimi1010 @tigercosmos I apologize, we do have tests for it which we run in CI as well:
I'm sorry for the confusion |
buffer
andbuffer2
raw memory allocations with a managed vector.buffer2
via resizing the vector instead.GetAdaptersInfo
will no longer be called twice if the first call does not experience buffer overflow.