Double-check crypto documentation of ECC #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... TR-02102-1 simply refers to the other TR.
ECDSA: Verification checks the x-coordinate of the computed point,
not the entire point.
ECKCDSA: The public point is denoted by Q not q.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jack performed a refactoring (introducing new helper-structures) in ECC to prepare for #3979 to be used in 3.6.0 (see #4027). The actual implementations (ECDH, ECDSA, ECGDSA, ECKCDSA) won't change much in 3.5.0, though. Fixes here are mostly details and inconsistencies I found on the way. Note that the commits bear more details about the actual changes.