This repository has been archived by the owner on May 18, 2021. It is now read-only.
Cut v1.0.0 #268
Merged
Cut v1.0.0 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58a435a to
7dd5bdf
Compare
(cherry picked from commit 7051a13)
56d6633 to
bfeab79
Compare
|
Reworked to get #277 in. Turns out we do need vendoring for all the USB HID stuff, so I added it back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://github.com/segmentio/aws-okta/wiki/v2.0.0-design-doc#rollout, this will be v1.0.0. v1.x will be maintenance only while we get v2.0.0 released.
I decided to abandon checking
vendor/in. With the go module proxy added in 1.13 (and backported to 1.12), we should be safe against e.g. Github going down.Everything is
internalnow; nobody should be able to importaws-okta. Kinda wish this was the default with Go (or there was a way to mark a module as non-importable entirely)