Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support not setting traits on Mixpanel #434

Merged
merged 1 commit into from
Sep 22, 2015
Merged

Support not setting traits on Mixpanel #434

merged 1 commit into from
Sep 22, 2015

Conversation

f2prateek
Copy link
Contributor

@f2prateek f2prateek force-pushed the mp-update branch 2 times, most recently from b4e39f8 to 6312800 Compare September 18, 2015 22:24
@f2prateek
Copy link
Contributor Author

This is the current behvaiour:

First check if setAllTraitsByDefault is true.
If setAllTraitsByDefault is true, do the same thing as before and exit.

If setAllTraitsByDefault is false, check if there are any mixpanel options.
If there are no mixpanel options, then return early.

If there are mixpanel options, then iterate over all superProperties and peopleProperties in those options, and pull traits into 2 seperate dictionaries dependending on what's in those options.

Then map those dictionaries to Mixpanel's semantic properties.

f2prateek added a commit that referenced this pull request Sep 22, 2015
Support not setting traits on Mixpanel
@f2prateek f2prateek merged commit 59192c3 into master Sep 22, 2015
@f2prateek f2prateek deleted the mp-update branch September 22, 2015 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants