[CHANNELS-1156] remove email unsub link when unsubcribe tag not present #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenkataNeeharikaKondipati
previously approved these changes
Jul 19, 2024
miguelpdiaz8
previously approved these changes
Jul 22, 2024
alfrimpong
reviewed
Jul 22, 2024
...stination-actions/src/destinations/engage-messaging-sendgrid/sendEmail/SendEmailPerformer.ts
Show resolved
Hide resolved
1515812
alfrimpong
approved these changes
Jul 22, 2024
|
@joe-ayoub-segment Can this one be included in tomorrow's deploy? |
joe-ayoub-segment
approved these changes
Jul 23, 2024
|
hi @CesarAyuso PR deployed. |
marinhero
pushed a commit
that referenced
this pull request
Aug 2, 2024
…nt (#2198) * fix: remove email unsub link when unsubcribe tag not present * chore: add unit test and comment
harsh-joshi99
pushed a commit
that referenced
this pull request
Aug 16, 2024
…nt (#2198) * fix: remove email unsub link when unsubcribe tag not present * chore: add unit test and comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic that will remove the unsubscribe link provided from Personas Subscription Service. We remove the unsubscribe link when there is no replacement tag in the html.
JIRA: https://segment.atlassian.net/browse/CHANNELS-1156
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.