Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S3 Actions] rename env variable #2194

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[S3 Actions] rename env variable #2194

merged 1 commit into from
Jul 18, 2024

Conversation

varadarajan-tw
Copy link
Contributor

Renames env variable to be consistent with other vars.

Testing

Testing not required.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@varadarajan-tw varadarajan-tw requested a review from a team as a code owner July 18, 2024 15:23
@varadarajan-tw varadarajan-tw merged commit 93bbc3e into main Jul 18, 2024
11 checks passed
@varadarajan-tw varadarajan-tw deleted the updates-s3-iam branch July 18, 2024 15:24
nick-Ag added a commit that referenced this pull request Jul 18, 2024
@nick-Ag
Squashed commit of the following:
628c708 
commit 0a1285a
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 15:08:29 2024 -0700

    Generates types

commit 8f5f5ed
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 15:04:14 2024 -0700

    WIP on an inexplicably not passing unit test

commit fc4f5ed
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 14:05:48 2024 -0700

    Checks for existence of user selected audience. Saves audience name and ID when returning from hook

commit a2a642c
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 12:58:03 2024 -0700

    WIP - verifying selected audience exists and saving it's ID as output

commit a022704
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 12:47:32 2024 -0700

    Removes description param from creating an audience per PRD

commit 49add30
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 12:44:07 2024 -0700

    Pulls down 200 most recent audiences in dynamic field response

commit c2f3e32
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 12:35:50 2024 -0700

    Removes pagination related code - that work will be saved for later :)

commit 6078690
Merge: b831f7b c9ecf66
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Thu Jul 18 12:31:29 2024 -0700

    Merge branch 'main' into fbca-retl-hook

commit c9ecf66
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Thu Jul 18 17:53:59 2024 +0200

    fixing non null assertion (#2195)

commit 93bbc3e
Author: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com>
Date:   Thu Jul 18 20:54:52 2024 +0530

    [S3 Actions] rename env variable (#2194)

commit 695a7fd
Author: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com>
Date:   Thu Jul 18 19:35:25 2024 +0530

    [S3 Action] Updates get credentials to assume intermediary role  (#2193)

    * Add support for external Id

    * [s3 action] add steps to assume intermediary role

    * update description

commit 7bb55fd
Author: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com>
Date:   Thu Jul 18 15:16:23 2024 +0530

    [version-packages] add support for versioning packages and merging to release branch (#2184)

    * [version-packages] allow version-package workflow to create PRs to release branch

    * cut version branch from base_branch input

commit bc532a7
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Thu Jul 18 11:41:07 2024 +0200

    registering aws-s3 destination (#2191)

commit 4d3d6c3
Author: Jeremy Pang <jeremyjpang@gmail.com>
Date:   Thu Jul 18 02:09:29 2024 -0700

    Add S3 Destination (#2117)

    * initial push

    * added subfolder functionality

    * removing various commented code and cleanup for PR

    * cleaning up operation file and removing snapshot.test.ts

    * fixing index.ts and operations.ts errors

    * updating s3 with unit test failure fixes

    * revising all changes, tested to make sure they work

    * defining interface for credentials

    * fixing undefined unit tests

    * fixing folderName undefined value

    * trying to fix undefined

    * non null assertation block added

    * updating yarn.lock to that of master branch

    * feat(code): add uploadCsv test; update yarn.lock

    * cleaning up comments

    * removing console log in performBatch

    * fixing trycatch wrapper and removing data const

    * fixing test failures

    * fixing error message

    * removing console.log

    * refactored changes from meeting with Jeremy

    * refactor

    * changing everyting

    * adding operations

    * more done

    * removed error validate

    * added credentials checking

    * fixing upload function

    * fixed double payload

    * more progress

    * filename fix

    * fix addnl props traits

    * add steps to assume intermediary role

    * removing test

    ---------

    Co-authored-by: Mayur Pitale <mpitale@twilio.com>
    Co-authored-by: Jason Sooter <7215306+JasonSooter@users.noreply.github.com>
    Co-authored-by: Joe Ayoub <joe.ayoub@segment.com>
    Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com>

commit b831f7b
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Wed Jul 17 15:14:15 2024 -0700

    Sets paging return such that the previous page was the current page

commit 365690e
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Wed Jul 17 15:09:14 2024 -0700

    Can pass dynamicFieldContext & paging into local server request

commit 037534c
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Wed Jul 17 14:37:23 2024 -0700

    Fixes build

commit 48fa746
Author: eden-ohana <71877898+eden-ohana@users.noreply.github.com>
Date:   Wed Jul 17 11:59:15 2024 +0300

    Taboola actions - add alphabetic account id description (#2181)

    * add alphabetic account id

    * generate

commit 1e9d616
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Tue Jul 16 16:55:05 2024 -0700

    WIP on a pagination mechanism for dynamic fields

commit 151d26c
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Tue Jul 16 16:14:03 2024 -0700

    Adds a dynamic audience field, pulls down all customaudiences as choices

commit 27e4903
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Tue Jul 16 15:29:46 2024 -0700

    Adds required customer_file_source field

commit 60d2291
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Tue Jul 16 12:26:51 2024 -0700

    WIP - first draft of a FacebookClient class, including an untested createAudience hook for retl

commit 5ba6c09
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Tue Jul 16 12:05:23 2024 -0700

    Introduces shared adAccountId top-level setting and audienceSetting

commit 0a20b76
Author: Nick Aguilar <nicholas.aguilar@segment.com>
Date:   Tue Jul 16 12:02:16 2024 -0700

    Removes delete action, add action. Introduces single sync action
marinhero pushed a commit that referenced this pull request Aug 2, 2024
@varadarajan-tw @marinhero
[S3 Actions] rename env variable (#2194)
04e9791
harsh-joshi99 pushed a commit that referenced this pull request Aug 16, 2024
@varadarajan-tw @harsh-joshi99
[S3 Actions] rename env variable (#2194)
ab43473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment approved these changes

Assignees
No one assigned
Labels
mode:cloud team:segment-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varadarajan-tw @joe-ayoub-segment