Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FBCAPI version to v20 #2190

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

itsarijitray
Copy link
Contributor

@itsarijitray itsarijitray commented Jul 18, 2024

This Pull request is to update API version from v18 to v20 in Facebook Conversions API.

We upgrading Facebook Marketing API upgrade to v20 as v18 is slated for deprecation by August 13, 2024.

Ticket: https://segment.atlassian.net/browse/STRATCONN-3925

A flag based rollout will be done for the integration where if the flag is enabled, the API will accept the newer canary version for the Facebook APIs.

Monitoring for the flag rollout can be done through the below datadog dashboard.

Flag on gate: https://flagon.segment.com/families/centrifuge-destinations/gates/facebook-capi-actions-canary-version

Datadog Dashboard: https://segment.datadoghq.com/dashboard/ndz-m7d-w2g/facebook-destinations?fromUser=false&refresh_mode=sliding&tpl_var_environment%5B0%5D=stage&view=spans&from_ts=1721394535441&to_ts=1721999335441&live=true

Testing

Stage Test Screenshots:

Datadog Link: https://segment.datadoghq.com/dashboard/ndz-m7d-w2g?fromUser=true&refresh_mode=sliding&tpl_var_environment%5B0%5D=stage&tpl_var_integration=facebook-app-events&view=spans&from_ts=1721388193311&to_ts=1721389093311&live=true

Screenshot 2024-07-19 at 5 07 50 PM Screenshot 2024-07-19 at 5 08 06 PM Screenshot 2024-07-19 at 5 08 34 PM Screenshot 2024-07-19 at 5 09 05 PM Screenshot 2024-07-19 at 5 09 12 PM Screenshot 2024-07-19 at 5 09 24 PM Screenshot 2024-07-19 at 5 11 37 PM Screenshot 2024-07-19 at 5 12 25 PM

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@nick-Ag
Copy link
Member

nick-Ag commented Jul 18, 2024

Hey @itsarijitray - would you mind expanding the description with some details on how you tested? ie: what routes did you hit? Did you send thru data and verify it arrived in the destination? Did you test the oauth flow (if applicable)?

@itsarijitray
Copy link
Contributor Author

itsarijitray commented Jul 19, 2024

Hey @itsarijitray - would you mind expanding the description with some details on how you tested? ie: what routes did you hit? Did you send thru data and verify it arrived in the destination? Did you test the oauth flow (if applicable)?

Hey @nick-Ag, This PR is WIP. Marking it as draft.

@itsarijitray itsarijitray marked this pull request as draft July 19, 2024 05:02
@itsarijitray itsarijitray marked this pull request as ready for review July 26, 2024 14:01
@brennan
Copy link
Contributor

brennan commented Jul 26, 2024

Thanks, @itsarijitray, what is the plan and cadence for the rollout? Once you decide, please add the schedule to your test doc, the related Jira ticket, and please announce rollout to new tiers in Slack. 🚀

@joe-ayoub-segment joe-ayoub-segment merged commit 8d67bf5 into main Jul 29, 2024
11 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the upgrade/STRATCONN-3921 branch July 29, 2024 16:08
marinhero pushed a commit that referenced this pull request Aug 2, 2024
harsh-joshi99 pushed a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants