Revert [Stratconn 3257] Add batching to segment connections (#1859) #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -603,7 +603,7 @@ export class Destination<Settings = JSONObject, AudienceSettings = JSONObject> { | |||
| audienceSettings = events[0].context?.personas?.audience_settings as AudienceSettings | |||
| } | |||
|
|
|||
| return action.executeBatch({ | |||
| await action.executeBatch({ | |||
There was a problem hiding this comment.
this revert to actions-core might break few integration test cases. Do you have the PR to fix those tests in integrations?
There was a problem hiding this comment.
Yes , I am on it
There was a problem hiding this comment.
@varadarajan-tw please review integration's PR https://github.com/segmentio/integrations/pull/2925
varadarajan-tw
approved these changes
Jul 23, 2024
|
hi @Innovative-GauravKochar PR deployed. |
marinhero
pushed a commit
that referenced
this pull request
Aug 2, 2024
harsh-joshi99
pushed a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1859
This Pull request is to to remove Segment Connections batching changes.
Jira ticket:- https://segment.atlassian.net/browse/STRATCONN-3716
Interrelated PRs:- https://github.com/segmentio/integrations-go/pull/419
https://github.com/segmentio/integrations/pull/2925
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.