Add phone number as identifier #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/destination-actions/src/destinations/klaviyo/removeProfile/index.ts
Show resolved
Hide resolved
...s/destination-actions/src/destinations/klaviyo/removeProfileFromList/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/removeProfile/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/addProfileToList/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/addProfileToList/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
| @@ -5,6 +5,10 @@ export interface Payload { | |||
| * The user's email to send to Klavio. | |||
| */ | |||
| email?: string | |||
| /** | |||
| * Individual's phone number in E.164 format. If SMS is not enabled and if you use Phone Number as identifier, then you have to provide one of Email or External ID. | |||
There was a problem hiding this comment.
Would Klaviyo throw an error if the phone number is not E.164 format?
There was a problem hiding this comment.
Do you think we should do a validation on our end? Would Klaviyo reject the entire batch if one event fails E.164 check?
| @@ -163,17 +166,26 @@ export async function getProfiles( | |||
| const response = await request(`${API_URL}/profiles/?filter=any(${filterId})`, { | |||
| method: 'GET' | |||
| }) | |||
| const data: GetProfileResponse = await response.json() | |||
| profileIds.push(...data.data.map((profile: Profile) => profile.id)) | |||
| const res: GetProfileResponse = await response.json() | |||
There was a problem hiding this comment.
fyi - you could actually use response.data directly to get parsed JSON object. No need to run await response.json() again. This is an inbuilt feature of our RequestClient.
packages/destination-actions/src/destinations/klaviyo/removeProfile/__tests__/index.test.ts
Show resolved
Hide resolved
...s/destination-actions/src/destinations/klaviyo/removeProfileFromList/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
...s/destination-actions/src/destinations/klaviyo/removeProfileFromList/__tests__/index.test.ts
Show resolved
Hide resolved
Comment on lines
301
to
304
| if (profile.phone_number && !validatePhoneNumber(profile.phone_number)) { | ||
| return false | ||
| } | ||
| return profile.email || profile.phone_number || profile.external_id |
There was a problem hiding this comment.
just a nit: you could probably do something like this and move the undefined check to validatePhoneNumber
Suggested change
| if (profile.phone_number && !validatePhoneNumber(profile.phone_number)) { | |
| return false | |
| } | |
| return profile.email || profile.phone_number || profile.external_id | |
| return profile.email || validatePhoneNumber(profile.phone_number) || profile.external_id |
There was a problem hiding this comment.
I think this will keep the profiles which have invalid phone number but also has either email or external_id, we want to filter those out as well since Klaviyo will throw error for those too.
varadarajan-tw
approved these changes
Aug 12, 2024
|
hi @harsh-joshi99 this PR has been deployed. |
sayan-das-in
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Add phone number as identifier in add profile to list and remove profile from list * add phone number for remove profile action * Update snapshot * Update tests * Fix test descriptions * Add E.164 validation in all actions, update test cases, update snapshots * Revert non engage actions changes to original state (splitting large PR) * Add removeProfile actions changes * Update snapshots
harsh-joshi99
added a commit
that referenced
this pull request
Aug 16, 2024
* Add phone number as identifier in add profile to list and remove profile from list * add phone number for remove profile action * Update snapshot * Update tests * Fix test descriptions * Add E.164 validation in all actions, update test cases, update snapshots * Revert non engage actions changes to original state (splitting large PR) * Add removeProfile actions changes * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add phone number as identifier in
add profile to list,remove profile from listandremove profileactions.JIRA -> STRATCONN-3866
Testing
Tested successfully in local and staging env.
Testing doc -> https://docs.google.com/document/d/1tlUdTiNfkiXF86yvW2faTpV8UGjI4sVzOqQ_2mzak0g/edit?usp=sharing
Add to list
Remove Profile
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.