Update dynamic field types to support dynamic array of objects #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-Ag
reviewed
Jul 11, 2024
| @@ -82,16 +85,27 @@ export interface ActionDefinition< | |||
| * This is likely going to change as we productionalize the data model and definition object | |||
| */ | |||
| dynamicFields?: { | |||
| [K in keyof Payload]?: Payload[K] extends object | |||
| [K in keyof Payload]?: IsArray<Payload[K]> extends never | |||
There was a problem hiding this comment.
This is some gnarly typescript, but I think I know what it's saying 😅
There was a problem hiding this comment.
Lol, yeah, getting really complex 😵💫
nick-Ag
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating types to support array of objects:
Note: Since adjusting types to be stricter, had to update the code in a couple of places to make sure the types for the ActionDefinition is accurate
Testing
Testing not required as this is a non-functional change.