Adjust Action Destination: First implementation + unit tests. #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smultani FYI - @seg-leonelsanches raised a PR for a new Destination for Adjust. |
|
hi @seg-leonelsanches thanks for raising this PR. As a next step could we meet 1:1 to talk through the design and code please? |
|
Hi @joe-ayoub-segment. Thanks for helping me with this. Yes, we can meet. Do you have my calendar? |
|
Hi @seg-leonelsanches - here's my Calendly. https://calendly.com/joe_ayoub/ |
packages/destination-actions/src/destinations/adjust/sendEvent/index.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/adjust/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/adjust/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/adjust/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/adjust/functions.ts
Outdated
Show resolved
Hide resolved
joe-ayoub-segment
requested changes
Jul 17, 2024
Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
|
hi @seg-leonelsanches let me know when this is ready for review. I'll move it to draft for now. |
|
@joe-ayoub-segment I think the destination is once again ready for review. |
|
Made some minor changes to get this ready for deploy. |
joe-ayoub-segment
approved these changes
Jul 23, 2024
|
hi @seg-leonelsanches PR deployed! |
marinhero
pushed a commit
that referenced
this pull request
Aug 2, 2024
* First implementation + unit tests. * Not using `rawData` in the type. That breaks the build. * Just not checking `data` for a `rawData` property. * Update packages/destination-actions/src/destinations/adjust/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> * Update packages/destination-actions/src/destinations/adjust/functions.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> * Update packages/destination-actions/src/destinations/adjust/functions.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> * Modifications requested in PR review. * Unit test adjustments. * Not using snapshot tests. * Updating generated types. * ready for deploy --------- Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Co-authored-by: Joe Ayoub <joe.ayoub@segment.com>
harsh-joshi99
pushed a commit
that referenced
this pull request
Aug 16, 2024
* First implementation + unit tests. * Not using `rawData` in the type. That breaks the build. * Just not checking `data` for a `rawData` property. * Update packages/destination-actions/src/destinations/adjust/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> * Update packages/destination-actions/src/destinations/adjust/functions.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> * Update packages/destination-actions/src/destinations/adjust/functions.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> * Modifications requested in PR review. * Unit test adjustments. * Not using snapshot tests. * Updating generated types. * ready for deploy --------- Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Co-authored-by: Joe Ayoub <joe.ayoub@segment.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our customers has dozens of apps, and hundreds (to not say thousands) of events that they want to send to Adjust. Additionally, these are all cloud events, sent by a service in their AWS environment.
To solve the problem, I had to implement something more dynamic: considering a free-form mapping, the customer can send their App Token + Event Token as part of the event, if they wish to do it (and not only in the
contextsection, orintegrationsection, as the legacy integration works).This should work normally with the plugins and libraries that already exist.
Testing