[STRAT-3865] | Re-authentication Flow for CreateAudience and GetAudience to handle 401 #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @varadarajan-tw for your valuable inputs. I have updated the PR , Please have a look! |
varadarajan-tw
approved these changes
Aug 6, 2024
|
hi @Innovative-GauravKochar PR deployed |
harsh-joshi99
pushed a commit
that referenced
this pull request
Aug 16, 2024
…nce to handle 401 (#2136) * resolved conflicts * Worked on reauthentication flow for createAudience and getAudience * Removed token refresh and Stats from amazon-amc * Removed commented and unnecessary code * Fixed AudienceDestinationDefinition * Made runFailedAttempt as reusable function across all execute blocks * Added a unit test case for reauthentication flow for createAudience and getAudience * added comment * PR review comments:- Added unit test case for non-oauth scheme and non 401 * Split failedAttemptHandler into three seperate methods --------- Co-authored-by: Gaurav Kochar <gaurav.kochar@segment.com> Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request is to make re-authentication flow for createAudience and getAudience whenever it throws 401 error.
Jira ticket :- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?assignee=63617339fc0cc7a600b03c6b&selectedIssue=STRATCONN-3865
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Tested completed Successfully in Staging