Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppFit Updated Track Event Payload #2124

Merged
merged 2 commits into from
Jul 9, 2024
Merged

AppFit Updated Track Event Payload #2124

merged 2 commits into from
Jul 9, 2024

Conversation

claude
Copy link
Contributor

@claude claude commented Jul 1, 2024

This PR adds 6 new fields to the track event action:

 appVersion: {
      label: 'App Version',
      description: 'The app version',
      type: 'string',
      default: {
        '@path': '$.context.app.version'
      }
    },
    deviceManufacturer: {
      label: 'Device Manufacturer',
      description: 'The device manufacturer',
      type: 'string',
      default: {
        '@path': '$.context.device.manufacturer'
      }
    },
    deviceModel: {
      label: 'Device Model',
      description: 'The device model',
      type: 'string',
      default: {
        '@path': '$.context.device.model'
      }
    },
    deviceAdvertisingId: {
      label: 'Device Advertising ID',
      description: 'The device advertising ID',
      type: 'string',
      default: {
        '@path': '$.context.device.advertisingId'
      }
    },
    ipAddress: {
      label: 'IP Address',
      description: 'The IP address of the client',
      type: 'string',
      default: {
        '@path': '$.context.ip'
      }
    },
  osVersion: {
      label: 'OS Version',
      description: 'The version of the operating system',
      type: 'string',
      default: {
        '@path': '$.context.os.version'
      }
    },

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

claude and others added 2 commits May 22, 2024 17:12
We needed to send a few other fields from the context to make our app
more robust.
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude lgtm. this weeks action deploy just went out, so this will likely get deployed next week.

Meanwhile, if you have any questions or concerns, do let me know.

@claude
Copy link
Contributor Author

claude commented Jul 2, 2024

Thanks @tcgilbert!

@joe-ayoub-segment joe-ayoub-segment merged commit 781959c into segmentio:main Jul 9, 2024
10 of 11 checks passed
@joe-ayoub-segment
Copy link
Contributor

hi @claude this PR has been deployed. Please confirm that you are happy with the change

@claude
Copy link
Contributor Author

claude commented Jul 9, 2024

Well the change got implemented, but things are failing on our end because I put the version in the wrong spot in the payload. @joe-ayoub-segment Any chance we can do a hotfix, or do we need to address on our end and fix next week?

@joe-ayoub-segment
Copy link
Contributor

hi @claude . Sorry to hear about that.
Is this causing issues for customers? Is there any data loss or corruption?
Best regards,
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants